various bugfixes

This commit is contained in:
Simon
2026-01-13 18:13:51 +00:00
parent aaff7d00c6
commit 34992242b7
21 changed files with 243 additions and 289 deletions

View File

@@ -3,14 +3,14 @@ use crate::api::ClientVersion;
use crate::providers::Provider;
use crate::status::*;
use crate::util::cache::VideoCache;
use crate::util::discord::send_discord_error_report;
use crate::util::discord::{format_error_chain, send_discord_error_report};
use crate::util::requester::Requester;
use crate::util::time::parse_time_to_seconds;
use crate::videos::{ServerOptions, VideoItem};
use async_trait::async_trait;
use error_chain::error_chain;
use htmlentity::entity::{decode, ICodedDataTrait};
use htmlentity::entity::{ICodedDataTrait, decode};
use std::sync::{Arc, RwLock};
use std::{thread, vec};
use titlecase::Titlecase;
@@ -50,7 +50,7 @@ impl HypnotubeProvider {
let url = self.url.clone();
let categories = Arc::clone(&self.categories);
thread::spawn(move || {
thread::spawn(async move || {
let rt = match tokio::runtime::Builder::new_current_thread()
.enable_all()
.build()
@@ -58,14 +58,16 @@ impl HypnotubeProvider {
Ok(rt) => rt,
Err(e) => {
eprintln!("tokio runtime failed: {e}");
let _ = futures::executor::block_on(send_discord_error_report(
&e,
send_discord_error_report(
e.to_string(),
Some(format_error_chain(&e)),
Some("HypnoTube Provider"),
Some("Failed to create tokio runtime"),
file!(),
line!(),
module_path!(),
));
)
.await;
return;
}
};
@@ -74,13 +76,15 @@ impl HypnotubeProvider {
if let Err(e) = Self::load_categories(&url, Arc::clone(&categories)).await {
eprintln!("load_categories failed: {e}");
send_discord_error_report(
&e,
e.to_string(),
Some(format_error_chain(&e)),
Some("HypnoTube Provider"),
Some("Failed to load categories during initial load"),
file!(),
line!(),
module_path!(),
).await;
)
.await;
}
});
});
@@ -89,10 +93,7 @@ impl HypnotubeProvider {
async fn load_categories(base: &str, cats: Arc<RwLock<Vec<FilterOption>>>) -> Result<()> {
let mut requester = Requester::new();
let text = requester
.get(
&format!("{base}/channels/"),
Some(Version::HTTP_11),
)
.get(&format!("{base}/channels/"), Some(Version::HTTP_11))
.await
.map_err(|e| Error::from(format!("{}", e)))?;
@@ -123,7 +124,7 @@ impl HypnotubeProvider {
}
Ok(())
}
fn build_channel(&self, clientversion: ClientVersion) -> Channel {
let _ = clientversion;
Channel {
@@ -140,8 +141,7 @@ impl HypnotubeProvider {
.iter()
.map(|c| c.title.clone())
.collect(),
options: vec![
ChannelOption {
options: vec![ChannelOption {
id: "sort".to_string(),
title: "Sort".to_string(),
description: "Sort the Videos".to_string(),
@@ -193,10 +193,7 @@ impl HypnotubeProvider {
"longest" => "longest",
_ => "videos",
};
let video_url = format!(
"{}/{}/page{}.html",
self.url, sort_string, page
);
let video_url = format!("{}/{}/page{}.html", self.url, sort_string, page);
let old_items = match cache.get(&video_url) {
Some((time, items)) => {
if time.elapsed().unwrap_or_default().as_secs() < 60 * 5 {
@@ -210,14 +207,15 @@ impl HypnotubeProvider {
}
};
let mut requester = options.requester.clone().unwrap();
let text = requester.get(&video_url, Some(Version::HTTP_11)).await.unwrap();
let text = requester
.get(&video_url, Some(Version::HTTP_11))
.await
.unwrap();
if text.contains("Sorry, no results were found.") {
eprint!("Hypnotube query returned no results for page {}", page);
return vec![];
}
let video_items: Vec<VideoItem> = self
.get_video_items_from_html(text.clone())
.await;
let video_items: Vec<VideoItem> = self.get_video_items_from_html(text.clone()).await;
if !video_items.is_empty() {
cache.remove(&video_url);
cache.insert(video_url.clone(), video_items.clone());
@@ -242,7 +240,10 @@ impl HypnotubeProvider {
};
let video_url = format!(
"{}/search/videos/{}/{}/page{}.html",
self.url, query.trim().replace(" ","%20"), sort_string, page
self.url,
query.trim().replace(" ", "%20"),
sort_string,
page
);
// Check our Video Cache. If the result is younger than 1 hour, we return it.
let old_items = match cache.get(&video_url) {
@@ -258,9 +259,19 @@ impl HypnotubeProvider {
vec![]
}
};
let mut requester = options.requester.clone().unwrap();
let text = match requester.post(format!("{}/searchgate.php", self.url).as_str(), format!("q={}&type=videos", query.replace(" ","+")).as_str(), vec![("Content-Type", "application/x-www-form-urlencoded")]).await.unwrap().text().await {
let text = match requester
.post(
format!("{}/searchgate.php", self.url).as_str(),
format!("q={}&type=videos", query.replace(" ", "+")).as_str(),
vec![("Content-Type", "application/x-www-form-urlencoded")],
)
.await
.unwrap()
.text()
.await
{
Ok(t) => t,
Err(e) => {
eprint!("Hypnotube search POST request failed: {}", e);
@@ -273,9 +284,7 @@ impl HypnotubeProvider {
eprint!("Hypnotube query returned no results for page {}", page);
return vec![];
}
let video_items: Vec<VideoItem> = self
.get_video_items_from_html(text.clone())
.await;
let video_items: Vec<VideoItem> = self.get_video_items_from_html(text.clone()).await;
if !video_items.is_empty() {
cache.remove(&video_url);
cache.insert(video_url.clone(), video_items.clone());
@@ -285,10 +294,7 @@ impl HypnotubeProvider {
video_items
}
async fn get_video_items_from_html(
&self,
html: String
) -> Vec<VideoItem> {
async fn get_video_items_from_html(&self, html: String) -> Vec<VideoItem> {
if html.is_empty() || html.contains("404 Not Found") {
eprint!("Hypnotube returned empty or 404 html");
return vec![];
@@ -302,47 +308,59 @@ impl HypnotubeProvider {
Some(b) => b,
None => {
eprint!("Hypnotube Provider: Failed to get block from html");
let err = Error::from(ErrorKind::Parse("html".into()));
let _ = futures::executor::block_on(send_discord_error_report(
&err,
Some("Hypnotube Provider"),
Some(&format!("Failed to get block from html:\n```{html}\n```")),
file!(),
line!(),
module_path!(),
));
let e = Error::from(ErrorKind::Parse("html".into()));
send_discord_error_report(
e.to_string(),
Some(format_error_chain(&e)),
Some("Hypnotube Provider"),
Some(&format!("Failed to get block from html:\n```{html}\n```")),
file!(),
line!(),
module_path!(),
)
.await;
return vec![];
},
}
};
let mut items = vec![];
for seg in block.split("<!-- item -->").skip(1){
for seg in block.split("<!-- item -->").skip(1) {
let video_url = match seg
.split(" href=\"")
.nth(1)
.and_then(|s| s.split('"').next()) {
Some(url) => url.to_string(),
None => {
eprint!("Hypnotube Provider: Failed to parse video url from segment");
let err = Error::from(ErrorKind::Parse("video url".into()));
let _ = futures::executor::block_on(send_discord_error_report(
&err,
Some("Hypnotube Provider"),
Some(&format!("Failed to parse video url from segment:\n```{seg}\n```")),
file!(),
line!(),
module_path!(),
));
continue;
}
};
.and_then(|s| s.split('"').next())
{
Some(url) => url.to_string(),
None => {
eprint!("Hypnotube Provider: Failed to parse video url from segment");
let e = Error::from(ErrorKind::Parse("video url".into()));
send_discord_error_report(
e.to_string(),
Some(format_error_chain(&e)),
Some("Hypnotube Provider"),
Some(&format!(
"Failed to parse video url from segment:\n```{seg}\n```"
)),
file!(),
line!(),
module_path!(),
)
.await;
continue;
}
};
let mut title = seg
.split(" title=\"")
.nth(1)
.and_then(|s| s.split('"').next())
.unwrap_or_default().trim().to_string();
.unwrap_or_default()
.trim()
.to_string();
title = decode(title.clone().as_bytes()).to_string().unwrap_or(title).titlecase();
title = decode(title.clone().as_bytes())
.to_string()
.unwrap_or(title)
.titlecase();
let id = video_url
.split('/')
.nth(4)
@@ -364,7 +382,7 @@ impl HypnotubeProvider {
.unwrap_or("")
.to_string();
let duration = parse_time_to_seconds(&raw_duration).unwrap_or(0) as u32;
let views = seg
.split("<span class=\"icon i-eye\"></span>")
.nth(1)
@@ -411,7 +429,7 @@ impl Provider for HypnotubeProvider {
return res;
}
fn get_channel(&self, v: ClientVersion) -> Channel {
self.build_channel(v)
fn get_channel(&self, v: ClientVersion) -> Option<Channel> {
Some(self.build_channel(v))
}
}